Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate light cluster patch file #13655

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

BD103
Copy link
Member

@BD103 BD103 commented Jun 3, 2024

Objective

Solution

  • Regenerate the patch file. (The location has been moved to cluster/mod.rs.)

Testing

  • Run git apply tools/example-showcase/reduce-light-cluster-config.patch
    • It should change bevy_pbr/src/cluster/mod.rs on line 239, decreasing total and z_slices.
  • CI's validation checks should also verify that this works, though only after it gets merged.

@BD103 BD103 added C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy A-Build-System Related to build systems or continuous integration P-Regression Functionality that used to work but no longer does. Add a test for this! X-Uncontroversial This work is generally agreed upon D-Domain-Agnostic Can be tackled by anyone with generic programming or Rust skills S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 3, 2024
@BD103
Copy link
Member Author

BD103 commented Jun 3, 2024

The patch file was regenerated by manually modifying cluster/mod.rs, then running git diff > out.patch. If / when this happens again, the steps are pretty simple. :)

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 3, 2024
@mockersf mockersf added this pull request to the merge queue Jun 3, 2024
Merged via the queue into bevyengine:main with commit 6038d15 Jun 3, 2024
36 checks passed
@BD103 BD103 deleted the fix-light-cluster-patch branch June 3, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Build-System Related to build systems or continuous integration C-Bug An unexpected or incorrect behavior D-Domain-Agnostic Can be tackled by anyone with generic programming or Rust skills D-Trivial Nice and easy! A great choice to get started with Bevy P-Regression Functionality that used to work but no longer does. Add a test for this! S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants