Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subdivisions to PlaneMeshBuilder #13580

Merged
merged 4 commits into from
Jun 3, 2024
Merged

Add subdivisions to PlaneMeshBuilder #13580

merged 4 commits into from
Jun 3, 2024

Conversation

IceSentry
Copy link
Contributor

Objective

  • Plane subdivision was removed without providing an alternative

Solution

  • Add subdivision to the PlaneMeshBuilder

Migration Guide

If you were using Plane subdivisions, you now need to use Plane3d::default().mesh().subdivisions(10)

fixes #13258

@IceSentry IceSentry added A-Math Fundamental domain-agnostic mathematical operations C-Feature A new feature, making something new possible labels May 30, 2024
@IceSentry IceSentry added this to the 0.14 milestone May 30, 2024
@IceSentry IceSentry added the D-Straightforward Simple bug fixes and API improvements, docs, test and examples label May 30, 2024
@IceSentry IceSentry added A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels May 30, 2024
@IceSentry IceSentry added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels May 31, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 3, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 3, 2024
Merged via the queue into bevyengine:main with commit bb51635 Jun 3, 2024
27 checks passed
@bugsweeper bugsweeper mentioned this pull request Jun 11, 2024
Open
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweatherley mweatherley mweatherley approved these changes

@Olle-Lukowski Olle-Lukowski Olle-Lukowski approved these changes

@NiseVoid NiseVoid NiseVoid approved these changes

Assignees
No one assigned
Labels
A-Math Fundamental domain-agnostic mathematical operations A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.14
Development

Successfully merging this pull request may close these issues.

PlaneMeshBuilder should include a configurable amount of subdivision for the mesh
5 participants
@IceSentry @mweatherley @NiseVoid @Olle-Lukowski @alice-i-cecile