Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Motion blur should sample onscreen fragments with no depth #13573

Merged

Conversation

aevyrie
Copy link
Member

@aevyrie aevyrie commented May 30, 2024

Objective

  • Motion blur does not currently work with skyboxes or anything else that does not write to depth.

Solution

  • When computing blur, include fragments with no depth, as long as they are onscreen.

Testing

  • Tested with the examples - the motion_blur example uncovered a bug with this fix, where offscreen pixels where now being sampled and causing artifacts.
  • Attached example showing the skybox being sampled in the blur (note the feathering on edges):
Screen.Recording.2024-05-30.at.1.34.55.AM.mp4

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels May 30, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue May 30, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label May 30, 2024
Merged via the queue into bevyengine:main with commit 16fe7e6 May 30, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants