Implemented Reflect for (almost) all bevy_math types
#13537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Usability
MrGVSV
approved these changes
May 27, 2024
crates/bevy_math/src/float_ord.rs
Outdated
| @@ -14,6 +17,7 @@ use std::{ | |||
| /// Wrapping a float with `FloatOrd` breaks conformance with the standard | |||
| /// by sorting `NaN` as less than all other numbers and equal to any other `NaN`. | |||
| #[derive(Debug, Copy, Clone)] | |||
| #[cfg_attr(feature = "bevy_reflect", derive(Reflect), reflect(Debug))] | |||
There was a problem hiding this comment.
We can also add the following it looks like:
Suggested change
| #[cfg_attr(feature = "bevy_reflect", derive(Reflect), reflect(Debug))] | |
| #[cfg_attr(feature = "bevy_reflect", derive(Reflect), reflect(Debug, PartialEq, Hash))] |
There was a problem hiding this comment.
Ah right, I was only looking at the derives. Not the manual, impls.
alice-i-cecile
approved these changes
May 27, 2024
alice-i-cecile
added
the
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #13535.
Solution
I implemented
Reflectfor close to all math types now, except for some types that it would cause issues (like some boxed types).Testing
Changelog
Reflect.