-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move bevy_math
Reflect
impls
#13520
Merged
Merged
Move bevy_math
Reflect
impls
#13520
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
2970bc0
Moved Reflect impls from bevy_reflect to bevy_math.
Olle-Lukowski b27640b
Moved Reflect impls from bevy_reflect to bevy_math
Olle-Lukowski d932088
Fix compilation errors
Olle-Lukowski 84986ca
Removed reflect feature from bevy_math
Olle-Lukowski a986370
Properly updated code.
Olle-Lukowski da43104
Formatting fixed
Olle-Lukowski 4f480ed
Hopefully fixed everything now
Olle-Lukowski 82849ae
Added reflect impl for Rhombus.
Olle-Lukowski 30ccc9f
Removed glob imports, added reflect(Default)
Olle-Lukowski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Could we avoid glob importing here? The
serialize
feature really only applies toReflectSerialize
andReflectDeserialize
. Other items, likeReflect
andReflectDefault
, don't require that feature. I think specifying the items manually clarifies why this particular feature gate is used.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah sure, I'll go ahead and update it along with your other suggestions, they are all valid concerns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!