-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a primitive sampling showcase example #13519
Conversation
The generated |
Please give suggestions on code quality, visual and performance improvements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Might be almost too fancy for just demonstrating sampling, but it does showcase it well and is visually appealing :) A screenshot or video of this would be a great fit for the 0.14 release notes too!
Left just a few non-blocking consistency nits. Also the keyboard inputs for zooming are sort of flipped and/or partially broken like we discussed on Discord, and for example pressing the non-numpad version of the minus/hyphen doesn't work with my Nordic (Finnish) keyboard layout, but I probably wouldn't block over it
Co-authored-by: Joona Aalto <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! The input issue seems to just be that the physical keys (KeyCode
) don't map to the correct logical keys with my keyboard layout, but I don't think we have a good clean approach to do it properly, and the other examples also just use key codes.
Objective
Solution
sampling_primitives
examples which shows all the 3D primitives being sampled, with a firefly aesthetic.Testing
cargo run --example sampling_primitives
Changelog
Added
sampling_primitives
, to showcase all the 3D sampleable primitives.Additional notes:
This example borrowed a bunch of code from the other sampling example, by @mweatherley.
In future updates this example should be updated with new 3D primitives as they become sampleable.