-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a few typos #13404
Merged
Merged
Fix a few typos #13404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bushrat011899
added
C-Docs
An addition or correction to our documentation
D-Trivial
Nice and easy! A great choice to get started with Bevy
labels
May 17, 2024
bushrat011899
approved these changes
May 17, 2024
JMS55
approved these changes
May 17, 2024
alice-i-cecile
added
the
S-Blocked
This cannot move forward until something else changes
label
May 17, 2024
Blocked until #13414 is merged to avoid making a mess. |
alice-i-cecile
added
the
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
label
May 17, 2024
jgayfer
approved these changes
May 17, 2024
alice-i-cecile
added
S-Blocked
This cannot move forward until something else changes
and removed
S-Blocked
This cannot move forward until something else changes
labels
May 23, 2024
nicoburns
approved these changes
May 30, 2024
alice-i-cecile
removed
the
S-Blocked
This cannot move forward until something else changes
label
Jun 3, 2024
No longer blocked; just need to wait for the linked PR to get merged and then I'll update this to main again :) |
alice-i-cecile
added
the
S-Blocked
This cannot move forward until something else changes
label
Jun 3, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 4, 2024
…3662) # Objective - #13414 did not have the intended effect. - #13404 is still blocked ## Solution - Re-adds #13347. Co-authored-by: Zachary Harrold <[email protected]> Co-authored-by: Jamie Ridding <[email protected]> Co-authored-by: BD103 <[email protected]>
alice-i-cecile
removed
the
S-Blocked
This cannot move forward until something else changes
label
Jun 4, 2024
The most complex two-line typo fix PR I've ever merged 😓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-Docs
An addition or correction to our documentation
D-Trivial
Nice and easy! A great choice to get started with Bevy
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fix a few typos I spotted while looking over #13347
Solution
Fix em