Fix leftover references to children when despawning audio entities #12407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not able to test this morning. Would appreciate someone making sure this works properly. |
rparrett
force-pushed
the
audio-despawn-recursive
branch
from
6c3d3ee to
0d15411
Compare
alice-i-cecile
requested changes
Mar 10, 2024
TrialDragon
added
C-Bug
james7132
added
the
M-Needs-Migration-Guide
|
It looks like your PR is a breaking change, but you didn't provide a migration guide. Could you add some context on what users should update when this change get released in a new version of Bevy? |
alice-i-cecile
approved these changes
Mar 11, 2024
james7132
approved these changes
Mar 11, 2024
james7132
added
the
S-Ready-For-Final-Review
mockersf
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #12402
Solution
Use
despawn_recursiveinstead ofdespawnfor despawningPlaybackMode::Despawnaudio.Migration Guide
PlaybackSettings::DESPAWN(PlaybackMode::Despawn) now despawns the audio entity's children as well. If you were relying on the previous behavior, you may be able to usePlaybackMode::Remove, or you may need to usePlaybackMode::Onceand manage your audio component lifecycle manually.