-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fps overlay #12382
Fps overlay #12382
Conversation
Can you add an example for this? It should be in its own |
Something we should consider in addition to a basic FPS overlay is GPU and GPU timings for rendering: #8067 + #9135. Possibly also using the automatic traces generated from systems to show the top ~10 system times per frame out of all systems. EDIT: I apologize for the scope creep, but if we're going to add in-app performance overlays, I feel like it's worth showing more data. Just pure FPS is not a great indication of performance. The alternative is we tell people to use tracy every time they run their app, which is already hooked up to give FPS and system timings. |
Fully onboard, but I would prefer for this to be done as a follow up, if that's not a problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with the state of the tool. I have a couple comments though
I only found third-party solutions for Vulkan |
Sorry for force-pushing, accidentally pushed wrong note |
Co-authored-by: Alice Cecile <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's still work to do in terms of exposing a nice API for configuring these things, but I'm happy to get this merged now to enable us to actually have some sample tools to abstract over.
Objective
bevy_dev_tools
and creation of new ones #12351Solution
FpsOverlayPlugin
FpsOverlayConfig
Preview on default settings