Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "features" feature #12373

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Remove "features" feature #12373

merged 1 commit into from
Mar 8, 2024

Conversation

yrns
Copy link
Contributor

@yrns yrns commented Mar 8, 2024

I think this was meant to be default = [] which is the default.

alice-i-cecile
alice-i-cecile approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging as trivial 😂

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Diagnostics Logging, crash handling, error reporting and performance analysis C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed C-Bug An unexpected or incorrect behavior labels Mar 8, 2024
@alice-i-cecile alice-i-cecile enabled auto-merge March 8, 2024 00:40
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 8, 2024
Merged via the queue into bevyengine:main with commit ffb1bc6 Mar 8, 2024
34 checks passed
spectria-limina pushed a commit to spectria-limina/bevy that referenced this pull request Mar 9, 2024
@yrns @spectria-limina
Remove "features" feature (bevyengine#12373)
0dfc02d 
I think this was meant to be `default = []` which is the default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Diagnostics Logging, crash handling, error reporting and performance analysis C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yrns @alice-i-cecile