Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move ci testing to dev_tools #12371

Merged
merged 2 commits into from
Mar 7, 2024
Merged

move ci testing to dev_tools #12371

merged 2 commits into from
Mar 7, 2024

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Mar 7, 2024

Objective

Solution

  • Move the parts doing the work of ci testing to the dev tools

@mockersf mockersf added the A-Dev-Tools Tools used to debug Bevy applications. label Mar 7, 2024
@alice-i-cecile alice-i-cecile requested review from matiqo15 and BD103 March 7, 2024 22:15
alice-i-cecile
alice-i-cecile approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. I'm perfectly happy with this solution.

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Build-System Related to build systems or continuous integration C-Code-Quality A section of code that is hard to understand or change labels Mar 7, 2024
@pablo-lua
Copy link
Contributor

Good. I was wondering if we could do something like moving the screenshot function to the crate, turns out that we could :D

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 7, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 7, 2024
Merged via the queue into bevyengine:main with commit 7148639 Mar 7, 2024
33 checks passed
spectria-limina pushed a commit to spectria-limina/bevy that referenced this pull request Mar 9, 2024
@mockersf @spectria-limina
move ci testing to dev_tools (bevyengine#12371)
973fef9 
# Objective

- Fix bevyengine#12356
- better isolation of ci testing tools in dev tools instead of being in
various crates

## Solution

- Move the parts doing the work of ci testing to the dev tools
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablo-lua pablo-lua pablo-lua approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@matiqo15 matiqo15 Awaiting requested review from matiqo15

@BD103 BD103 Awaiting requested review from BD103

Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration A-Dev-Tools Tools used to debug Bevy applications. C-Bug An unexpected or incorrect behavior C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CiTestingConfig is blocking bevy_dev_tools from using bevy_render
3 participants
@mockersf @pablo-lua @alice-i-cecile