Extracting ambient light from light.rs, and creating light directory #12369
Conversation
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
alice-i-cecile
added
A-Rendering
|
Looks good: nice and straightforward. Once merge conflicts are resolved and we have a second approval (from anyone) I'll merge this in for you :) |
|
One more file moved out of the root module yay. |
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
also |
Agreed this should be done, but no preference on one vs several PRs :) |
|
yup, moving those other light variants is the plan, just wanted to make sure I felt good about the process and that this looked good before doing the rest of the file! |
|
@nbielans - it looks like there are some merge conflicts. Could you update the PR by merging in the changes from |
|
@superdump just merged the changes! |
# Objective - in #12369, patched file changed location, so patch is failing ## Solution - fix patch
…ht/mod.rs (#12656) # Objective Follow up from PR #12369 to extract lighting structs from light/mod.rs into their own file. Part of the Purdue Refactoring Team's goals issue #12349 ## Solution - Moved PointLight from light/mod.rs to light/point_light.rs - Moved SpotLight from light/mod.rs to light/spot_light.rs - Moved DirectionalLight from light/mod.rs to light/directional_light.rs
Objective
Beginning of refactoring of light.rs in bevy_pbr, as per issue #12349
Create and move light.rs to its own directory, and extract AmbientLight struct.
Solution