Beautify example showcase site URLs #12348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doonv
approved these changes
Mar 6, 2024
rparrett
reviewed
Mar 6, 2024
|
I think this requires storing a separate value for the "slugified" category. The "slugified" category is now being displayed in headers on the website: 
Pinged François, because I'm not sure what ramifications this will have on other tools that utilize |
Co-authored-by: Rob Parrett <[email protected]>
atlv24
reviewed
Mar 7, 2024
Co-authored-by: vero <[email protected]>
afonsolage
approved these changes
Mar 7, 2024
|
This will break all existing links to a specific example |
Hmm, yeah. Looking thru stuff again I'll redo this in such a way that it only impacts the website list and will have aliases for the previous URLs rather than the current... naive solution I did which impacts everything in retrospect. |
alice-i-cecile
added
the
S-Ready-For-Final-Review
This was referenced Jul 28, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 30, 2024
…#14500) # Objective Fixes bevyengine/bevy-website#1558 Followup to #12348 For the website pages extra link, it needs kebab case for the category name and a trailing forward slash to make the link for the Bevy website correct and not have unnecessary redirections. ## Solution Changes the category name to kebab case for the extra link, and adds a trailing forward slash to the link. ## Testing I have tested these changes. Clone my fork with the changes in `bevy-website/generate-wasm-examples/` then `cd bevy && git switch bevy-website/1558_fix_beautify_example_links && cd ..` and then `./generate_wasm_examples.sh` to generate examples. Afterwards runs `zola serve` and go to `http://127.0.0.1:1111/examples` and hover over or inspect the cards links / anchors to see that the link is now correct, click on any of the cards to see that there is no redirects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The current example showcase site URLs have white-space and caps in them which looks ugly as an URL.
Fixes bevyengine/bevy-website#736
Solution
To fix this the example showcase tool now makes the category used for the site sections lowercase, separated by a hyphen rather than white-space, and without parentheses.