Example how to update state #10716
Closed
Example how to update state #10716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItsDoot
added
C-Docs
This is a neat idea. Can you spin out an issue for it? |
alice-i-cecile
approved these changes
Nov 24, 2023
TrialDragon
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
LGTM and the AppMock works as a solution for now until #3786 is resolved and hopefully removes the need. (Tho, this does have conflicts that needs to be resolved before merging).
TrialDragon
added
the
S-Ready-For-Final-Review
|
@stepancheg can you please resolve merge conflicts? |
|
This seems to not be importing necessary stuff; doc tests are failing. |
alice-i-cecile
added
the
S-Adopt-Me
Merged
|
Closing as adopted. |
auto-merge was automatically disabled
May 13, 2024 13:02
Pull request was closed
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 13, 2024
# Objective adopted from #10716 adds example for updating state --------- Co-authored-by: Stepan Koltsov <[email protected]> Co-authored-by: Alice Cecile <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm adding
AppMockagain. This is not very nice looking code.I'm thinking about this alternative: create a crate like
bevy_mocks, which could be added as dev-dependency to most crates. AFAIU dev-dependencies are available in doctests.bevy_mockswould contain interfaces of most frequently utilities likeApporInput<KeyCode>and dummy implementations. That would be sufficient to write compile-only tests which would look concise in sources and illustrative in published rustdocs.