Skip to content

Commit

Permalink
Check examples screenshots on windows (#16010)
Browse files Browse the repository at this point in the history
# Objective

- Checks screenshots on Windows
- Progress towards #15918 

## Solution

- Checks screenshots on Windows
- Also disable the helmet gltf scene in windows ci as it doesn't work
  • Loading branch information
mockersf authored Oct 20, 2024
1 parent 34c9a64 commit ec26842
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 3 deletions.
14 changes: 13 additions & 1 deletion .github/workflows/validation-jobs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,8 @@ jobs:
secrets: inherit

run-examples-on-windows-dx12:
if: ${{ github.event_name == 'merge_group' }}
# also run when pushed to main to update reference screenshots
if: ${{ github.event_name != 'pull_request' }}
runs-on: windows-latest
timeout-minutes: 30
steps:
Expand Down Expand Up @@ -191,6 +192,17 @@ jobs:
name: example-run-windows
path: example-run/

compare-windows-screenshots:
name: Compare Windows screenshots
needs: [run-examples-on-windows-dx12]
uses: ./.github/workflows/send-screenshots-to-pixeleagle.yml
with:
commit: ${{ github.sha }}
branch: ${{ github.ref_name }}
artifact: screenshots-windows
os: windows
secrets: inherit

run-examples-on-wasm:
if: ${{ github.event_name == 'merge_group' }}
runs-on: ubuntu-22.04
Expand Down
4 changes: 2 additions & 2 deletions examples/testbed/3d.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ fn main() {
.init_state::<Scene>()
.enable_state_scoped_entities::<Scene>()
.add_systems(OnEnter(Scene::Light), light::setup)
.add_systems(OnEnter(Scene::Gltf), gltf::setup)
.add_systems(OnEnter(Scene::Animation), animation::setup)
.add_systems(Update, switch_scene);

// Those scenes don't work in CI on Windows runners
#[cfg(not(all(feature = "bevy_ci_testing", target_os = "windows")))]
app.add_systems(OnEnter(Scene::Bloom), bloom::setup);
app.add_systems(OnEnter(Scene::Bloom), bloom::setup)
.add_systems(OnEnter(Scene::Gltf), gltf::setup);

app.run();
}
Expand Down

0 comments on commit ec26842

Please sign in to comment.