Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network: IP_MULTICAST_LOOP should be set to false/0 #205

Merged
merged 1 commit into from
Jan 10, 2023
+2 −2
Merged

network: IP_MULTICAST_LOOP should be set to false/0 #205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/network/multicastsocket.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ int setup_multicast_socket(const char *_multicast_ip, unsigned short _multicast_
}

// allow broadcast
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this comment be adapted aswell to something like "don't receive our own packets"?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this. Indeed this comment should be removed. I will do it in another commit.

loop = 1;
loop = 0;
if (setsockopt(sock,
IPPROTO_IP,
IP_MULTICAST_LOOP,
Expand Down Expand Up @@ -85,4 +85,4 @@ int remove_multicast_socket(int socket) {
return -1;
}
return 0;
}
}