network: IP_MULTICAST_LOOP should be set to false/0 #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If IP_MULTICAST_LOOP is left to true/1 the dawn instance will send the packet out and then receive it itself, this will generate a 'Remote PROBE updated client / BSSID = XX:XX:XX:XX:XX:XX / YY:YY:YY:YY:YY:YY' after every 'Local PROBE used to update client / BSSID = XX:XX:XX:XX:XX:XX / YY:YY:YY:YY:YY:YY'
|
Yes. You are right. Can you prefix the commit message with |
imwhocodes
changed the title
Flole998
reviewed
Jan 10, 2023
| @@ -45,7 +45,7 @@ int setup_multicast_socket(const char *_multicast_ip, unsigned short _multicast_ | |||
| } | |||
|
|
|||
| // allow broadcast | |||
There was a problem hiding this comment.
Shouldn't this comment be adapted aswell to something like "don't receive our own packets"?
There was a problem hiding this comment.
Thanks for spotting this. Indeed this comment should be removed. I will do it in another commit.
|
@PolynomialDivision I wasn't fast enough hahah |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
IP_MULTICAST_LOOPis left totrue/1the dawn instance will send the packet out and then receive it itself, this will generate a 'Remote PROBE updated client / BSSID = XX:XX:XX:XX:XX:XX / YY:YY:YY:YY:YY:YY' after every 'Local PROBE used to update client / BSSID = XX:XX:XX:XX:XX:XX / YY:YY:YY:YY:YY:YY'