Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing bzl_library dependencies #2292

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

brentleyjones
Copy link
Collaborator

No description provided.

@brentleyjones
Copy link
Collaborator Author

Depends on bazelbuild/apple_support#275.

@cgrindel
Copy link
Contributor

@brentleyjones Do you want me to put up a PR like this one to catch these missing bzl_library deps?

@cgrindel
Copy link
Contributor

Also, should we add the bzl deps test to apple_support as well?

@brentleyjones
Copy link
Collaborator Author

I think the latest stardoc, which has correct runfiles support, notices these just fine now? It's how I found these errors for example. Unless I'm misunderstanding and you believe there are more missing deps?

@cgrindel
Copy link
Contributor

The bzl_test that I added to rules_swift and some other repos ensures that the bzl_library targets have the correct deps going forward. Many repos do not generate their docs with every PR. If that is the case, then bzl_test ensures that bzl_library deps stay up-to-date.

@brentleyjones
Copy link
Collaborator Author

Okay. So we don't need it, since we check the docs on every PR.

@brentleyjones brentleyjones force-pushed the bj/add-missing-bzl_library-dependencies branch from 1cc422b to be0eb36 Compare October 17, 2023 17:40
@brentleyjones brentleyjones merged commit 8af9127 into master Oct 17, 2023
3 checks passed
@brentleyjones brentleyjones deleted the bj/add-missing-bzl_library-dependencies branch October 17, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants