Update dependencies and use latest archives #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerrymarino
approved these changes
Oct 19, 2023
jerrymarino
reviewed
Oct 19, 2023
|
A new rules_apple & rules_swift version will be tagged soon that include some stardoc fixes (which is why they're failing here) ill update this pr when theyre done. We essentially need: bazelbuild/rules_apple#2292 |
|
Ok thanks - I've filed an issue for the problems we ran into after the stardoc update at: |
luispadron
force-pushed
the
luis/update-dependencies-use-release-archives
branch
2 times, most recently
from
b7b957c to
1644e0b
Compare
|
Updated the PR to include rules_apple 3.1.0 and rules_swift 1.13.0 which fixes the issues we were seeing with stardoc and bzlmod. CI is now back to using bzlmod for the stardoc tests |
Updates the dependencies of the latest versions, fixes some bzlmod warnings introduced by rules_apple 3 PR ``` WARNING: For repository 'build_bazel_apple_support', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. WARNING: For repository 'build_bazel_rules_swift', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. ``` Additionally, moves the latest versions in `repositories.bzl` back to using the release archive instead of a git clone. Not sure why those were changed Finally, fixes issues with stardoc and rules_apple 3 + bzlmod. It re-enables bzlmod for stardoc in CI
luispadron
force-pushed
the
luis/update-dependencies-use-release-archives
branch
from
1644e0b to
b2d3bf9
Compare
|
Updated again to rules_apple 3.1.1 which brings one final fix for non bzlmod users. This should be ready now, @jszumski @thiagohmcruz when ya'll have a minute |
jszumski
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the dependencies of the latest versions, fixes some bzlmod warnings introduced by rules_apple 3 PR
Additionally, moves the latest versions in
repositories.bzlback to using the release archive instead of a GitHub on-demand archive. Not sure why those were changedFinally, fixes issues with stardoc and rules_apple 3 + bzlmod.
It re-enables bzlmod for stardoc in CI
Fixes #783