Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip incompatible_exclusive_test_sandboxed #16867

Conversation

gasparev
Copy link
Contributor

@gasparev gasparev commented Nov 28, 2022

@gasparev gasparev marked this pull request as ready for review November 28, 2022 17:31
@gasparev gasparev requested a review from a team as a code owner November 28, 2022 17:31
@sgowroji sgowroji added team-Remote-Exec Issues and PRs for the Execution (Remote) team awaiting-review PR is awaiting review from an assigned reviewer labels Nov 29, 2022
@meisterT meisterT requested a review from coeuvre November 29, 2022 10:15
@coeuvre
Copy link
Member

coeuvre commented Nov 30, 2022

Thanks for your PR!

There are hundreds tests inside google which rely on the old behaviour (that's why I added this flag instead of making the changes directly in #3791) so we can't just merge this PR without doing anything internally.

I can't migrate all the internal tests because of workload. To move this PR forward, I will try to disable this flag internally first.

@gasparev
Copy link
Contributor Author

Thanks @coeuvre

@gasparev
Copy link
Contributor Author

gasparev commented Dec 5, 2022

Hey @coeuvre did you have time to check whether disabling the flag internally works?

@copybara-service copybara-service bot closed this in 23580aa Dec 6, 2022
@coeuvre
Copy link
Member

coeuvre commented Dec 6, 2022

Internally we disabled this flag, and so far, everything looks good. (In case of something go wrong, I probably need to rollback this change).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review PR is awaiting review from an assigned reviewer team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants