Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flip default for --incompatible_exclusive_test_sandboxed #40

Open
alexeagle opened this issue Mar 22, 2022 · 2 comments
Open

Flip default for --incompatible_exclusive_test_sandboxed #40

alexeagle opened this issue Mar 22, 2022 · 2 comments
Assignees
@gasparev
Labels
bazel-flags Flip default for Bazel flags bounty-1000USD A contributor who completes this will be rewarded $1000

Comments

@alexeagle
Copy link
Contributor

Help to finish bazelbuild/bazel#3791 by finding Bazel CI projects which need this flag explicitly turned off, then land a PR in Bazel to flip the default for new projects.
@alexeagle alexeagle added the bounty-1000USD A contributor who completes this will be rewarded $1000 label Apr 20, 2022
@cgrindel cgrindel added the bazel-flags Flip default for Bazel flags label Aug 9, 2022
@cgrindel cgrindel moved this to Needs Implementation in Rules SIG Tracker Aug 9, 2022
@gasparev gasparev mentioned this issue Nov 29, 2022
Closed
2 tasks
@gasparev
Copy link

Hi, I'm flipping this here bazelbuild/bazel#16867. All the checks are green and the PR is ready to merge

@cgrindel cgrindel moved this from Needs Assignment to In Progress in Rules SIG Tracker Nov 29, 2022
copybara-service bot pushed a commit to bazelbuild/bazel that referenced this issue Dec 6, 2022
@gasparev @copybara-github
Flip incompatible_exclusive_test_sandboxed
23580aa 
Solves #3791 #16871 bazel-contrib/SIG-rules-authors#40
Steps to do before merging:

- [x] Bazel checks green #16868
- [x] Downstream projects green https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/1348

Closes #16867.

PiperOrigin-RevId: 493257706
Change-Id: I0f46d092a47a7c08e2436183c9cdc2cd92a0c379
@gasparev
Copy link

gasparev commented Dec 6, 2022

This can be closed after bazelbuild/bazel@23580aa

@cgrindel cgrindel moved this from In Progress to Done in Rules SIG Tracker Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gasparev gasparev

Labels
bazel-flags Flip default for Bazel flags bounty-1000USD A contributor who completes this will be rewarded $1000
Projects
Rules SIG Tracker
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexeagle @cgrindel @gasparev