Add RE2 release 2023-06-02.

[junyer]

Ping, @meteorcloudy? :)

[fmeum]

@junyer In case you have a chance to influence this: It would be great if upstream could publish release artifacts as the current source URL is not guaranteed to provide a consistent hash over time.

[junyer]

@junyer In case you have a chance to influence this: It would be great if upstream could publish release artifacts as the current source URL is not guaranteed to provide a consistent hash over time.

My understanding was that the issue had been resolved as per #69. Is that not actually the case? :(

[junyer]

Looking at the failed checks, I see that I totally forgot to configure dependencies on Abseil and GoogleTest. (Benchmark isn't in BCR, so I will have to exclude one of our targets.)

[fmeum]

My understanding was that the issue had been resolved as per #69. Is that not actually the case? :(

We thought so too, but it turned out that this was just miscommunication on GitHub's part and these links also aren't stable (see the rest of bazel-contrib/SIG-rules-authors#11 for all the details). The only stable artifacts are manually created release artifacts.

[junyer]

Unfortunately, I don't understand why the checks are now barfing on MODULE.bazel. Could someone please let me know?

[junyer]

We thought so too, but it turned out that this was just miscommunication on GitHub's part and these links also aren't stable (see the rest of bazel-contrib/SIG-rules-authors#11 for all the details). The only stable artifacts are manually created release artifacts.

I wonder whether https://code.googlesource.com/re2 can guarantee stability. 🤔

[junyer]

I wonder whether https://code.googlesource.com/re2 can guarantee stability. 🤔

I just downloaded the .tar.gz and .zip files and uploaded them straight back. The skip-url-stability-check label can be removed now. :)

Unfortunately, I don't understand why the checks are now barfing on MODULE.bazel. Could someone please let me know?

Herp derp. I messed up the patch. #shamecube

[junyer]

FYI, I made compatibility_level match the current SONAME.

[fmeum]

CI is still failing due to a reference to google/benchmark.

[junyer]

CI is still failing due to a reference to google/benchmark.

Mea culpa, I need to omit //:benchmark too.

[junyer]

I formatted MODULE.bazel and that rearranged things a bit more than I was expecting, but c'est la vie.

[fmeum]

My bad, forgot that the BCR doesn't test modules as root modules. If you want to run the tests, you will need to remove the dev_dependency param on the googletest dep.

[junyer]

My bad, forgot that the BCR doesn't test modules as root modules. If you want to run the tests, you will need to remove the dev_dependency param on the googletest dep.

No worries. Done. :)

[junyer]

RE2 recently started doing this to unbreak the Bazel CI, but I'm not sure what to do for the BCR CI...

[junyer]

Oh, I can just copycat what Abseil are doing here. And refactor to use matrix while I'm at it. :)

[junyer]

Good to go! :D