Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RE2 release 2023-09-01. #877

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Add RE2 release 2023-09-01. #877

merged 1 commit into from
Sep 1, 2023

Conversation

junyer
Copy link
Contributor

@junyer junyer commented Aug 31, 2023 •
edited
Loading

No description provided.

@meteorcloudy meteorcloudy added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Sep 1, 2023
meteorcloudy
meteorcloudy requested changes Sep 1, 2023
View reviewed changes
modules/re2/2023-09-01/MODULE.bazel Outdated Show resolved Hide resolved
@junyer junyer requested a review from meteorcloudy September 1, 2023 10:30
@junyer
Copy link
Contributor Author

junyer commented Sep 1, 2023 

ImportError: Python version mismatch: module was compiled for Python 3.7, but the interpreter version is incompatible: 3.11.4 (main, Jul 26 2023, 13:23:24) [Clang 16.0.3 ].

How odd. I can yeet //python:all from test for now though.

@junyer
Copy link
Contributor Author

junyer commented Sep 1, 2023

Ugh. A couple of the matrix platforms are still sad about Python. I have yeeted @re2//python:re2 from build as well.

@junyer junyer requested a review from fmeum September 1, 2023 10:47
fmeum
fmeum approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@fmeum fmeum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for cutting some deps!

I missed that Python was an actual prod dependency. While that could be extracted into a separate module, the current solution is fine as well.

meteorcloudy
meteorcloudy approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@meteorcloudy meteorcloudy merged commit b5127f4 into bazelbuild:main Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmeum fmeum fmeum approved these changes

@meteorcloudy meteorcloudy meteorcloudy approved these changes

Assignees
No one assigned
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@junyer @meteorcloudy @fmeum