Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support openssl from bcr #5

Open
wants to merge 4 commits into
base: bazelboost-1.83.0
Choose a base branch
from

Conversation

zaucy
Copy link
Member

@zaucy zaucy commented Dec 10, 2024

No description provided.

Matthew Young and others added 2 commits June 11, 2024 08:18
…l query` for targets that rely on `boost.asio` due to the fact that OpenSSL is not in BCR yet.
@zaucy zaucy changed the title feat/use openssl from bcr @zaucy feat: support openssl from bcr Dec 10, 2024
@zaucy zaucy changed the title @zaucy feat: support openssl from bcr feat: support openssl from bcr Dec 10, 2024
@andrewkatson
Copy link

Did you want any assistance? I get a new computer tomorrow! So I can finally work on Mac, Linux, and Windows.

@zaucy
Copy link
Member Author

zaucy commented Dec 13, 2024

Yeah feel free! I'm not sure when I'll get around to finishing it, but I'll be keeping tabs if you do!

@andrewkatson
Copy link

Okay! I get the last part today so hopefully Ill have a setup by tomorrow. Do you know what the main blockers right now are?

@zaucy
Copy link
Member Author

zaucy commented Dec 16, 2024

what I noticed immediately is boost asio uses some openssl headers that seem to not be available on the openssl bcr module. I wasn't sure if I just misconfigured openssl though.

@andrewkatson
Copy link

oh intriguing. because openssl is the super set of boringssl. Ill reach out to the maintainer and see what they say.

@andrewkatson
Copy link

Ok I reached out and he told me to post raccoons-build/bazel-openssl-cc#1 which is their very first issue! @zaucy can you re-run the linux and windows checks.

@zaucy
Copy link
Member Author

zaucy commented Dec 17, 2024

turned off fail fast so they'll all run - also made you a maintainer so feel free to adjust this PR or run the gh action as much as you need

@andrewkatson
Copy link

andrewkatson commented Dec 17, 2024

Nice thank you! Looks like the windows error is on their side too: https://github.com/bazelboost/asio/actions/runs/12381745142/job/34560955188?pr=5

@zaucy
Copy link
Member Author

zaucy commented Dec 17, 2024

didn't realise they did a release recently - looks like its just Windows thats an issue

@andrewkatson
Copy link

Well I volunteered to add Windows support since I got openssl working on Windows previously. So we shall see. I am still building my computer but it will be done soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants