-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support openssl from bcr #5
base: bazelboost-1.83.0
Are you sure you want to change the base?
Conversation
…l query` for targets that rely on `boost.asio` due to the fact that OpenSSL is not in BCR yet.
Did you want any assistance? I get a new computer tomorrow! So I can finally work on Mac, Linux, and Windows. |
Yeah feel free! I'm not sure when I'll get around to finishing it, but I'll be keeping tabs if you do! |
Okay! I get the last part today so hopefully Ill have a setup by tomorrow. Do you know what the main blockers right now are? |
what I noticed immediately is boost asio uses some openssl headers that seem to not be available on the openssl bcr module. I wasn't sure if I just misconfigured openssl though. |
oh intriguing. because openssl is the super set of boringssl. Ill reach out to the maintainer and see what they say. |
Ok I reached out and he told me to post raccoons-build/bazel-openssl-cc#1 which is their very first issue! @zaucy can you re-run the linux and windows checks. |
turned off fail fast so they'll all run - also made you a maintainer so feel free to adjust this PR or run the gh action as much as you need |
Nice thank you! Looks like the windows error is on their side too: https://github.com/bazelboost/asio/actions/runs/12381745142/job/34560955188?pr=5 |
didn't realise they did a release recently - looks like its just Windows thats an issue |
Well I volunteered to add Windows support since I got openssl working on Windows previously. So we shall see. I am still building my computer but it will be done soon. |
No description provided.