Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl/conf.h not found #1

Open
andrewkatson opened this issue Dec 17, 2024 · 5 comments
Open

openssl/conf.h not found #1

andrewkatson opened this issue Dec 17, 2024 · 5 comments

Comments

@andrewkatson
Copy link

andrewkatson commented Dec 17, 2024

@zaucy and I are working on getting boost asio working with openssl. It already works with boringssl but we hit the following error when trying to build for MacOS. I am not sure if there are other issues with it but will re-run the checks to see.

https://github.com/bazelboost/asio/actions/runs/12247097103/job/34164294195?pr=5 from bazelboost/asio#5

@andrewkatson
Copy link
Author

andrewkatson commented Dec 17, 2024

Looks like ubuntu passes but Windows has an error on your side too https://github.com/bazelboost/asio/actions/runs/12381745142/job/34560955188?pr=5

but it seems intentional like this doesn't support Windows yet. I have my own openssl that works with Windows if you needed some help: https://github.com/andrewkatson/openssl

@andrewkatson
Copy link
Author

We saw your recent release and now only Windows is outstanding!

@andrewkatson
Copy link
Author

@illicitonion can you PTAL

@illicitonion
Copy link
Contributor

Thanks for the attention! Yeah I don't have the Windows expertise to get this going, but I'm happy to review a PR which did. I imagine it would take the shape of:

  1. Add another platform to the platforms list in generate.py - I'm not sure which platform, as Windows has a few.
  2. Edit BUILD.openssl.bazel to load constants from the newly generated .bzl file, and expand all the selects to cover the new constants.
  3. Editing .github/workflows/pr.yaml to add windows-latest to the list of OSes in pr-test.

@andrewkatson
Copy link
Author

I'll take a stab at it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants