Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bal 2983 - Lack of Session Expiration on dev env #2894

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

bal 2983 - Lack of Session Expiration on dev env #2894

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
733743a
fix: pt issue regarrding cookies to be secured
liorzblrn Dec 13, 2024
ceebfc1
fix: pt issue regarrding cookies to be secured
liorzblrn Dec 13, 2024
8eeff22
fix: securty http only
liorzblrn Dec 13, 2024
108288a
Merge branch 'dev' of github.com:ballerine-io/ballerine into bal-2983
liorzblrn Dec 21, 2024
87a8f0d
fix: non secure
liorzblrn Dec 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions services/workflows-service/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,10 @@ const main = async () => {
cookieSession({
name: 'session',
keys: [env.SESSION_SECRET],
httpOnly: env.ENVIRONMENT_NAME === 'production',
secure: false,
sameSite: env.ENVIRONMENT_NAME === 'production' ? 'strict' : false,
httpOnly: env.ENVIRONMENT_NAME !== 'local',
secure: true,
// lax - Cookies are sent with same-site requests and some cross-site GET requests.
sameSite: env.ENVIRONMENT_NAME !== 'local' ? 'strict' : 'lax',
maxAge: 1000 * 60 * env.SESSION_EXPIRATION_IN_MINUTES,
}),
);
Expand Down
Loading