Add Routing source #186
Merged
Add Routing source #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zsoltk
commented
May 26, 2020
•
zsoltk
commented
- Separates Router & Back stack
- Abstracts away Back stack
- Implements new diffing algorithm based on any iterable routing history
- Adds permanent / empty / set based routing sources
- Removes previous hacky internal access of Router in RecyclerView support related classes
- Extracts activation from Actions to be separated by Router (default parent attach vs. client code attach like recycler view viewholders)
Can happen if a RoutingSource emits exactly 1 element and then calls onComplete
…menting RoutingSource)
This was referenced Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.