Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add operation to precisely remove dialog configuration #164

Closed
zsoltk opened this issue Apr 27, 2020 · 1 comment
Closed

Add operation to precisely remove dialog configuration #164

zsoltk opened this issue Apr 27, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@zsoltk
Copy link
Contributor

zsoltk commented Apr 27, 2020

Current implementation depends on configuration resulting in dialog being the last one on the stack, and calling router.popBackStack() in DialogRoutingAction.

In most cases this is fine enough. However, there can be cases where this assumption isn't correct, resulting in unpredictable behaviour.

This can be improved by:

  • Passing info about specific configuration this dialog was created for. This needs to consider there can be repeated instances across the stack in different positions.
  • Creating back stack operation to remove a specific configuration from the stack
@zsoltk zsoltk added the enhancement New feature or request label Apr 27, 2020
@zsoltk
Copy link
Contributor Author

zsoltk commented Jun 1, 2020

Implemented as part of #186

@zsoltk zsoltk closed this as completed Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant