-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect { and [ for german keyboards on Windows #51
base: mainline
Are you sure you want to change the base?
Conversation
@yuting-fan @Yangtao-Hua can you review and fix this? It's hard to work with the Session Manager when |
Thanks for reaching out. We have received this request and will update here after the internal review. |
This also breaks french keyboard shortcuts for [ | { |
This should be the keys for french keyboards: session-manager-plugin/vendor/src/github.com/eiannone/keyboard/keyboard_windows.go Line 192 in c523002
@YujiaozhAws Maybe the whole functions ( session-manager-plugin/vendor/src/github.com/eiannone/keyboard/keyboard_windows.go Line 185 in c523002
|
I can confirm that on a french keyboard, AltGr doesn't work with the number keys from 2 to 8 (which corresponds to ASCII codes 50 to 56), but works fine with 9 (^), 0 (@) and other keys which have a third grapheme such as €]}¤. |
Why is this still not patched ? Every time I have to type any command which contains ~#{[|`\ I have to switch to Qwerty and use the on-screen keyboard, it's a real pain ! The issue is known, and so is the fix, so what is Amazon waiting for ? Please fix this !!! |
Issue #13
Description of changes:
The keys
{
(Alt Gr
+7
)[
(Alt Gr
+8
)are not detected on German keyboards...
Maybe the change has side effects. But it worked for me!
If you remove the
50
from this line, it might also fix the@
key for spain keyboards:session-manager-plugin/vendor/src/github.com/eiannone/keyboard/keyboard_windows.go
Line 186 in c523002
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.