Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect { and [ for german keyboards on Windows #51

Open
wants to merge 2 commits into
base: mainline
Choose a base branch
from

Conversation

BornToBeRoot
Copy link

Issue #13

Description of changes:

The keys

  • { (Alt Gr + 7)
  • [ (Alt Gr + 8)

are not detected on German keyboards...

Maybe the change has side effects. But it worked for me!

If you remove the 50 from this line, it might also fix the @ key for spain keyboards:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@BornToBeRoot BornToBeRoot changed the title Allow { and [ for german keyboards Detect { and [ for german keyboards Oct 27, 2022
@BornToBeRoot BornToBeRoot changed the title Detect { and [ for german keyboards Detect { and [ for german keyboards on Windows Oct 28, 2022
@BornToBeRoot
Copy link
Author

@yuting-fan @Yangtao-Hua can you review and fix this?

It's hard to work with the Session Manager when { and [ is not working...

@YujiaozhAws
Copy link
Contributor

Thanks for reaching out. We have received this request and will update here after the internal review.

@hot22shot
Copy link

This also breaks french keyboard shortcuts for [ | {
Quite an issue for me.

@BornToBeRoot
Copy link
Author

This should be the keys for french keyboards:

        case 52:
            e.key = KeyCtrl4
        case 53:
            e.key = KeyCtrl5

@YujiaozhAws Maybe the whole functions (r.virtual_key_code) doesn't make any sense or you could remove they key codes 50-56 from it:

@clienart-bmx
Copy link

I can confirm that on a french keyboard, AltGr doesn't work with the number keys from 2 to 8 (which corresponds to ASCII codes 50 to 56), but works fine with 9 (^), 0 (@) and other keys which have a third grapheme such as €]}¤.
Not being able to type ~#{[|`\ is of course very frustrating !

@clienart-bmx
Copy link

Why is this still not patched ? Every time I have to type any command which contains ~#{[|`\ I have to switch to Qwerty and use the on-screen keyboard, it's a real pain !

The issue is known, and so is the fix, so what is Amazon waiting for ?

Please fix this !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants