-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS SSM Plugin for aws-cli don't work correctly with spanish (from Spain) Keyboard layout #13
Comments
I'm experiencing the same thing (although using Swedish keyboard layout). A possible workaround is to
Optionally, if you don't want to stay on English layout:
Simply connecting with English layout and then switching back does not seem to be enough, only after sending the first character you can switch back and it will work until the session is closed. This needs to be repeated for each new session. This was tested on |
Same problem here with German keyboard layout. For example, the opening square bracket has the effect of "backspace". |
Same problem with German layout. Workaround doesn't help at all. Versions: |
As @dmazuronak mentioned the German Layout has same problems too. If i need a specific character like [ than i switch Layout to US English and start a new Session. It might work for some small works but will be getting awful when you need to change the whole time. |
The same problem with |
Same issue with frensh keyboard, you have to switch the keyboard to type this kind of char event by copy past |
Same problem with It looks like the underlying library is causing the problem: https://github.com/eiannone/keyboard The plugin is unusable for me... although I would like to replace SSH with AWS SSM.... |
@dmazuronak for me the |
I have had the opportunity to try out PowerShell 7. Unfortunately, I could not see any improvement. |
Same issue with Belgian keyboard: Pressing the @ results in 'nothing'.
Still no fix? |
@TeeFiX42 removing 50 from this line should fix the @ for spain&belgian keyboard. session-manager-plugin/vendor/src/github.com/eiannone/keyboard/keyboard_windows.go Line 186 in c523002
see #51 |
Hi @dmazuronak, i think the default input/output encoding in the console window is wrong. For me it worked on some powershell windows (e.g. Windows Terminal).... If you set this in Powershell:
before connecting to aws ssm, you should be able to use Edit:
I changed it to |
Why is this still not patched ? Every time I have to type any command which contains ~#{[|`\ I have to switch to Qwerty and use the on-screen keyboard, it's a real pain ! The issue is known, and so is the fix, so what is Amazon waiting for ? Please fix this !!! |
In case of German and other keyboards with AltGr keys, one offender is probably https://github.com/aws/session-manager-plugin/blob/7b544e9f381d809fd7117747d4b78b244addcf1e/vendor/src/github.com/eiannone/keyboard/keyboard_windows.go#LL96C5-L96C83
which must not trigger if Alt is also pressed. |
As mentioned before, copy/paste is also broken. Pasting the string |
@ngollan you can clone my fix and build the binaries yourself if you want: https://github.com/BornToBeRoot/session-manager-plugin/tree/mainline For me it's working fine with my own binaries ^^ Edit: I don't understand why AWS is not able to solve this problem that affects everyone who doesn't have an English keyboard. |
@BornToBeRoot does your change also fix pasting? |
@ngollan yes. Pasting I would also recommend doing this |
I get this on a german keyboard layout, i.e. square brackets are BACKSPACE. |
The solution of forcing |
@angelo-gelmini the But no one at aws cares about this problem (i also wrote to the support...). This project does not seem to be maintained anymore and I have to ask myself if it makes sense to continue using the AWS Session Manager or if I would rather use SSH. Also it's not a problem of the session manager plugin, but from the underlying go library which is not maintained... |
Connecting with a instance with the AWS SSM plugin on Windows 10 with the Spanish (from Spain) Keyboard layout using CMD and PowerShell (v 5.1 and 7.4) some characters are not recorded correctly, characters like ? @ }
The text was updated successfully, but these errors were encountered: