Allow ASN1_get_object to parse indefinite and universal #1994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1994 +/- ##
==========================================
- Coverage 78.89% 78.88% -0.01%
==========================================
Files 593 593
Lines 101965 101981 +16
Branches 14458 14461 +3
==========================================
+ Hits 80441 80448 +7
- Misses 20877 20887 +10
+ Partials 647 646 -1 ☔ View full report in Codecov by Sentry. |
justsmth
force-pushed
the
ruby-asn1
branch
3 times, most recently
from
0162031
to
1162b42
Compare
samuel40791765
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses: CryptoAlg-2693
Description of changes:
ASN1_get_object. Other places that parse ASN1 should be unaffected.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.