Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make 'echoMessage failure test' conditional #487

Merged
merged 1 commit into from
Apr 8, 2024
Merged

make 'echoMessage failure test' conditional #487

merged 1 commit into from
Apr 8, 2024

Conversation

jmklix
Copy link
Member

@jmklix jmklix commented Apr 5, 2024

Issue #, if available:
#486

Description of changes:
Make the echoMessage failure test a conditional_test. Don't have it run locally because it needs to connect to the echo server environment to succeed.

hostName: process.env.AWS_TEST_EVENT_STREAM_ECHO_SERVER_HOST ?? "",

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmklix jmklix linked an issue Apr 5, 2024 that may be closed by this pull request
@jmklix jmklix merged commit 52f549a into main Apr 8, 2024
10 checks passed
@jmklix jmklix deleted the issue_486 branch April 8, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failing (echoMessage failure)
2 participants