Test failing (echoMessage failure)

[maggiechew]

Describe the bug

Trying to fork to make suggestions, ran tests & was bug unrelated to changes (happens even directly after forking with no changes to main.)

echoMessage failure test - server side internal service error

Eventstream RPC client configuration must have a valid host name

  1067 |  */
  1068 | export function createRpcError(type: RpcErrorType, description: string, internalError?: CrtError, serviceError?: any) {
> 1069 |     return new RpcError({
       |            ^
  1070 |         type: type,
  1071 |         description: description,
  1072 |         internalError: internalError,

  at createRpcError (lib/eventstream_rpc.ts:1069:12)
  at Object.validateRpcClientConfig (lib/eventstream_rpc.ts:280:15)
  at Object.createClient (lib/echotestrpc.ts:24:21)
  at lib/echotestrpc.spec.ts:427:44
  at lib/echotestrpc.spec.ts:35:71
  at Object.<anonymous>.__awaiter (lib/echotestrpc.spec.ts:31:12)
  at Object.<anonymous> (lib/echotestrpc.spec.ts:426:82)

Test Suites: 1 failed, 1 total

Expected Behavior

All preexisting tests already merged into main should have be passing already; suggests tests were not run prior to merge or something else has changed.
Also over 20 skipped tests seems very extreme; suggests something needs to be addressed with tests overall.

Current Behavior

See bug description for stack trace & message.

Reproduction Steps

npm i
npm run test

Possible Solution

No response

Additional Information/Context

using VS code

SDK version used

v2 (?) latest commit 4425367

Environment details (OS name and version, etc.)

windows 11

[jmklix]

This test:

test('echoMessage failure test - server side internal service error', async () => {
    let client: echo_rpc.Client = echo_rpc.createClient(makeGoodConfig());

    await client.connect();

needs to connect to the test host to be able to run successfully.

hostName: process.env.AWS_TEST_EVENT_STREAM_ECHO_SERVER_HOST ?? "",

I have made to PR to make this a conditional_test. This and all of the other skipped tests need to be skipped because they don't have the echo server environment available. These test are made to run in the CI and they do pass successfully there. Thank you for the concern over the failing test.

[github-actions]

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.