Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log codebuild webhook trigger #13738

Merged
merged 5 commits into from
Apr 26, 2024
Merged

Conversation

0618
Copy link
Contributor

@0618 0618 commented Apr 25, 2024

Modified from #13735

There are several ways to trigger e2e tests:

  1. manually trigger it in a PR
  2. e2e test branch
  3. dev branch after a PR is merged

In order to know the status of the repo, we need to be notified timely when e2e test fails after a merge. So, we need to have a way to differentiate 3) from 1) and 2).

This PR is to add echos to log some infomation so that we'll be able to know in the builds log:

  1. how the build is triggered
  2. if the build was success

We the 2 info above, Cloudwatch is able to filter the datapoints and create a new metric so that we can set alarm from the metric.

Description of changes

log CODEBUILD_WEBHOOK_TRIGGER if a batch fails

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@0618 0618 marked this pull request as ready for review April 25, 2024 22:59
@0618 0618 requested a review from a team as a code owner April 25, 2024 22:59
sobolk
sobolk previously approved these changes Apr 25, 2024
awsluja
awsluja previously approved these changes Apr 26, 2024
@0618 0618 dismissed stale reviews from awsluja and sobolk via 3a37c09 April 26, 2024 16:37
@0618 0618 merged commit b8c8e5e into aws-amplify:dev Apr 26, 2024
5 checks passed
@0618 0618 mentioned this pull request Apr 29, 2024
6 tasks
@0618 0618 deleted the log-codebuildWebhookTrigger branch May 7, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants