Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log batch trigger #13748

Merged
merged 7 commits into from
Apr 29, 2024
Merged

fix: log batch trigger #13748

merged 7 commits into from
Apr 29, 2024

Conversation

0618
Copy link
Contributor

@0618 0618 commented Apr 29, 2024

Description of changes

After #13738, there are 2 problems found:

  1. the log only works if accountForFailures is true
  2. if CODEBUILD_WEBHOOK_TRIGGER is unset or null, accountForFailures would become the 5th param

In this PR:

  • moved the CODEBUILD_WEBHOOK_TRIGGER log out of the accountForFailures check
  • set a default value empty for CODEBUILD_WEBHOOK_TRIGGER

Issue #, if available

Description of how you validated changes

tested in codebuild

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@0618 0618 marked this pull request as ready for review April 29, 2024 19:44
@0618 0618 requested a review from a team as a code owner April 29, 2024 19:44
@0618 0618 merged commit 769211a into aws-amplify:dev Apr 29, 2024
5 checks passed
@0618 0618 deleted the log-batch-trigger branch April 29, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants