refactor: improve has_many interactions + add & add another

app/components/avo/actions_component.rb

@@ -93,7 +93,7 @@ def render_action_link(action)
   def action_data_attributes(action)
     {
       action_name: action.action_name,
-      "turbo-frame": Avo::ACTIONS_TURBO_FRAME_ID,
+      "turbo-frame": Avo::MODAL_FRAME_ID,
       action: "click->actions-picker#visitAction",
       "actions-picker-target": action.standalone ? "standaloneAction" : "resourceAction",
       disabled: is_disabled?(action),

app/components/avo/fields/has_one_field/show_component.html.erb

@@ -10,7 +10,7 @@
           icon: 'heroicons/outline/link',
           color: :primary,
           style: :text,
-          'data-turbo-frame': 'attach_modal' do %>
+          data_turbo_frame: Avo::MODAL_FRAME_ID do %>
           <%= t('avo.attach_item', item: @field.name.humanize(capitalize: false)) %>
         <% end %>
       <% end %>

app/components/avo/resource_component.rb

@@ -246,7 +246,7 @@ def render_attach_button(control)
       color: :primary,
       style: :text,
       data: {
-        turbo_frame: :attach_modal,
+        turbo_frame: Avo::MODAL_FRAME_ID,
         target: :attach
       } do
       control.label
@@ -282,7 +282,7 @@ def render_action(action)
       title: action.title,
       size: action.size,
       data: {
-        turbo_frame: Avo::ACTIONS_TURBO_FRAME_ID,
+        turbo_frame: Avo::MODAL_FRAME_ID,
         action_name: action.action.action_name,
         tippy: action.title ? :tooltip : nil,
         action: "click->actions-picker#visitAction",

app/components/avo/views/resource_index_component.rb

@@ -103,6 +103,7 @@ def attach_path
       paths: [*current_path, "new"],
       query: {
         view: @parent_resource&.view&.to_s,
+        for_turbo_frame: field&.try(:turbo_frame),
         for_attribute: field&.try(:for_attribute)
       }.compact
     )

app/controllers/avo/actions_controller.rb

@@ -101,14 +101,13 @@ def respond
             # Trigger download, removes modal and flash the messages
             [
               turbo_stream.download(content: Base64.encode64(@response[:path]), filename: @response[:filename]),
-              turbo_stream.close_action_modal,
+              turbo_stream.close_modal,
               turbo_stream.flash_alerts
             ]
           when :navigate_to_action
-            frame_id = Avo::ACTIONS_TURBO_FRAME_ID
             src, _ = @response[:action].link_arguments(resource: @action.resource, **@response[:navigate_to_action_args])
 
-            turbo_stream.turbo_frame_set_src(frame_id, src)
+            turbo_stream.turbo_frame_set_src(Avo::MODAL_FRAME_ID, src)
           when :redirect
             turbo_stream.redirect_to(
               Avo::ExecutionContext.new(target: @response[:path]).handle,
@@ -118,7 +117,7 @@ def respond
           when :close_modal
             # Close the modal and flash the messages
             [
-              turbo_stream.close_action_modal,
+              turbo_stream.close_modal,
               turbo_stream.flash_alerts
             ]
           else

app/controllers/avo/associations_controller.rb

@@ -64,8 +64,15 @@ def create
       respond_to do |format|
         if create_association
           format.html {
-            redirect_back fallback_location: resource_view_response_path,
-              notice: t("avo.attachment_class_attached", attachment_class: @related_resource.name)
+            redirect_back fallback_location: resource_view_response_path, notice: t("avo.attachment_class_attached", attachment_class: @related_resource.name)
+          }
+          format.turbo_stream {
+            actions = [turbo_stream.turbo_frame_reload(params[:turbo_frame])]
+
+            # We want to close the modal if the user wants to add just one record
+            actions << turbo_stream.close_modal if params[:button] != "attach_another"
+
+            render turbo_stream: actions
           }
         else
           flash[:error] = t("avo.attachment_failed", attachment_class: @related_resource.name)
@@ -104,6 +111,7 @@ def destroy
 
       respond_to do |format|
         format.html { redirect_to params[:referrer] || resource_view_response_path, notice: t("avo.attachment_class_detached", attachment_class: @attachment_class) }
+        format.turbo_stream { render turbo_stream: turbo_stream.turbo_frame_reload(params[:turbo_frame]) }
       end
     end
 

app/controllers/avo/base_controller.rb

@@ -109,7 +109,7 @@ def new
 
       # Handle special cases when creating a new record via a belongs_to relationship
       if params[:via_belongs_to_resource_class].present?
-        return render turbo_stream: turbo_stream.append("attach_modal", partial: "avo/base/new_via_belongs_to")
+        return render turbo_stream: turbo_stream.append(Avo::MODAL_FRAME_ID, partial: "avo/base/new_via_belongs_to")
       end
 
       set_actions
@@ -532,6 +532,7 @@ def resource_view_response_path
     def destroy_success_action
       respond_to do |format|
         format.html { redirect_to after_destroy_path, notice: destroy_success_message }
+        format.turbo_stream { render turbo_stream: turbo_stream.turbo_frame_reload(params[:turbo_frame]) }
       end
     end
 

app/helpers/avo/turbo_stream_actions_helper.rb

@@ -10,10 +10,10 @@ def flash_alerts
         template: @view_context.render(Avo::FlashAlertsComponent.new(flashes: @view_context.flash.discard))
     end
 
-    def close_action_modal
+    def close_modal
       turbo_stream_action_tag :replace,
-        target: Avo::ACTIONS_TURBO_FRAME_ID,
-        template: @view_context.turbo_frame_tag(Avo::ACTIONS_TURBO_FRAME_ID, data: {turbo_temporary: 1})
+        target: Avo::MODAL_FRAME_ID,
+        template: @view_context.turbo_frame_tag(Avo::MODAL_FRAME_ID, data: {turbo_temporary: 1})
     end
   end
 end

app/javascript/js/controllers/actions_picker_controller.js

@@ -12,7 +12,7 @@ export default class extends Controller {
   }
 
   get actionsShowTurboFrame() {
-    return document.querySelector('turbo-frame#actions_show')
+    return document.querySelector(`turbo-frame#${window.Avo.configuration.modal_frame_id}`)
   }
 
   enableTarget() {

app/views/avo/actions/show.html.erb

@@ -2,7 +2,7 @@
   <%= render Avo::LoadingComponent.new(title: "...") %>
 <% end %>
 
-<%= turbo_frame_tag Avo::ACTIONS_TURBO_FRAME_ID do %>
+<%= turbo_frame_tag Avo::MODAL_FRAME_ID do %>
   <div
     data-controller="<%= ["action", @action.get_stimulus_controllers].join(" ") %>"
     data-action-no-confirmation-value="<%= @action.no_confirmation %>"

app/views/avo/associations/new.html.erb

@@ -1,4 +1,4 @@
-<%= turbo_frame_tag 'attach_modal' do %>
+<%= turbo_frame_tag Avo::MODAL_FRAME_ID do %>
   <%
     url = Avo::Services::URIService.parse(avo.root_url.to_s)
       .append_paths('resources', params[:resource_name], params[:id], params[:related_name])
@@ -53,6 +53,7 @@
                 stacked: true,
                 classes: 'w-full'
               %>
+              <%= hidden_field_tag :turbo_frame, params[:for_turbo_frame] %>
             <% end %>
             <% @attach_fields&.each_with_index do |field, index| %>
               <%= render(Avo::Items::SwitcherComponent.new(
@@ -74,6 +75,9 @@
         <%= a_button 'data-action': 'click->modal#close', type: :button, size: :sm, style: :outline, color: :gray do %>
           <%= t('avo.cancel') %>
         <% end %>
+        <%= a_button type: :submit, value: :attach_another, style: :outline, color: :green, size: :sm do %>
+          <%= t('avo.attach_and_attach_another') %>
+        <% end %>
         <%= a_button type: :submit, style: :primary, color: :green, size: :sm do %>
           <%= t('avo.attach') %>
         <% end %>

app/views/avo/partials/_javascript.html.erb

@@ -11,4 +11,5 @@
     param_key: '<%= Avo::DynamicFilters.configuration.param_key %>'
   }
   <% end %>
+  Avo.configuration.modal_frame_id = '<%= ::Avo::MODAL_FRAME_ID %>'
 <% end %>

app/views/layouts/avo/application.html.erb

@@ -49,8 +49,7 @@
         </div>
       </div>
     </div>
-    <%= turbo_frame_tag Avo::ACTIONS_TURBO_FRAME_ID, data: {turbo_temporary: 1} %>
-    <%= render partial: "avo/partials/attach_modal" %>
+    <%= turbo_frame_tag Avo::MODAL_FRAME_ID, data: {turbo_temporary: 1} %>
     <%= render partial: "avo/partials/alerts" %>
     <%= render partial: "avo/partials/scripts" %>
     <%= render partial: "avo/partials/confirm_dialog" %>

lib/avo.rb

@@ -20,7 +20,7 @@ module Avo
   IN_DEVELOPMENT = ENV["AVO_IN_DEVELOPMENT"] == "1"
   PACKED = !IN_DEVELOPMENT
   COOKIES_KEY = "avo"
-  ACTIONS_TURBO_FRAME_ID = :actions_show
+  MODAL_FRAME_ID = :modal_frame
   ACTIONS_BACKGROUND_FRAME = :actions_background
 
   class LicenseVerificationTemperedError < StandardError; end

lib/avo/base_action.rb

@@ -61,11 +61,7 @@ def link_arguments(resource:, arguments: {}, **args)
           )
           .to_s
 
-        data = {
-          turbo_frame: Avo::ACTIONS_TURBO_FRAME_ID,
-        }
-
-        [path, data]
+        [path, {turbo_frame: Avo::MODAL_FRAME_ID}]
       end
 
       # Encrypt the arguments so we can pass sensible data as a query param.

spec/system/avo/actions_spec.rb

@@ -192,7 +192,7 @@
 
       click_on "Actions"
       click_on "Do Nothing"
-      expect(page).to have_css('turbo-frame#actions_show')
+      expect(page).to have_css('turbo-frame#modal_frame')
       expect(page).to have_selector(modal = "[role='dialog']")
       click_on "Run"
       expect(page).not_to have_selector(modal)
@@ -214,7 +214,7 @@
 
       click_on "Actions"
       click_on "Close modal"
-      expect(page).to have_css('turbo-frame#actions_show')
+      expect(page).to have_css('turbo-frame#modal_frame')
       expect(page).to have_selector(modal = "[role='dialog']")
       click_on "Run"
       expect(page).not_to have_selector(modal)