Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve has_many interactions + add & add another #3269

Merged
merged 36 commits into from
Sep 29, 2024

Conversation

adrianthedev
Copy link
Collaborator

@adrianthedev adrianthedev commented Sep 25, 2024

Description

Fixes #983

Makes the association interactions much smoother:

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

Manual review steps

  1. Step 1
  2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

Copy link

codeclimate bot commented Sep 25, 2024

Code Climate has analyzed commit 98c6097 and detected 0 issues on this pull request.

View more on Code Climate.

spec/system/avo/actions_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/actions_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/attach_success_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/attach_success_spec.rb Outdated Show resolved Hide resolved
@Paul-Bob
Copy link
Contributor

Paul-Bob commented Sep 28, 2024

In tests, when using URLs with a turbo_frame like "/admin/resources/users/#{user.slug}/posts?turbo_frame=has_many_field_posts&view_type=table" the content is rendered inside the frame but the src is missing from the frame which results in the environment not accurately reflecting the real one..

This leads to some false positive results especially now that we use turbo_frame_reload which requires the src to reload the frame.

To properly test turbo frames in real scenarios I moved some tests from feature to system

@Paul-Bob Paul-Bob merged commit 2069460 into main Sep 29, 2024
22 checks passed
@Paul-Bob Paul-Bob deleted the refactor/improve-has-many-interations branch September 29, 2024 07:38
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Keep scroll position or don't reload everything when interacting with an association on the resource show page
2 participants