Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: firefox record selection persists on reload & firefox row border #2065

Merged
merged 6 commits into from
Dec 4, 2023
Merged

fix: firefox record selection persists on reload & firefox row border #2065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7862887
fix: firefox record selection persists on reload
Paul-Bob Nov 28, 2023
398af2e
fix actions_spec
Paul-Bob Nov 28, 2023
2e7d8c5
remove relative from tr to fix firefox row border-b render
Paul-Bob Nov 28, 2023
e687b9b
try loading action
Paul-Bob Nov 28, 2023
a522868
action for no confirmation redirect test
Paul-Bob Nov 28, 2023
d572bf4
Merge branch 'main' into fix/firefox_record_selection
Paul-Bob Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/components/avo/index/table_row_component.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<%# hover:z-[21] removed from tr class to solve flickering actions component on row controls and z-20 changed to z-21%>
<tr
class="bg-white hover:bg-gray-50 hover:shadow-row relative z-21 border-b"
class="bg-white hover:bg-gray-50 hover:shadow-row z-21 border-b"
data-component-name="<%= self.class.to_s.underscore %>"
<%== item_selector_init @resource %>
data-resource-name="<%= @resource.class.to_s %>"
Expand Down
2 changes: 2 additions & 0 deletions app/helpers/avo/resources_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ def item_selector_input(floating: false, size: :md)
type: "checkbox",
name: t("avo.select_item"),
title: t("avo.select_item"),
autocomplete: :off,
class: "mx-3 rounded checked:bg-primary-400 focus:checked:!bg-primary-400 #{floating ? "absolute inset-auto left-0 mt-3 z-10 hidden group-hover:block checked:block" : ""} #{size.to_sym == :lg ? "w-5 h-5" : "w-4 h-4"}",
data: {
action: 'input->item-selector#toggle input->item-select-all#selectRow',
Expand All @@ -59,6 +60,7 @@ def item_select_all_input
type: "checkbox",
name: t("avo.select_all"),
title: t("avo.select_all"),
autocomplete: :off,
class: "mx-3 rounded w-4 h-4 checked:bg-primary-400 focus:checked:!bg-primary-400",
data: {
action: "input->item-select-all#toggle",
Expand Down
Loading