ACP-77: Update ConvertSubnetTx
#3397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
commented
Sep 18, 2024
StephenButtolph
commented
Sep 18, 2024
StephenButtolph
changed the base branch from
implement-acp-77-tx-base
to
implement-acp-77-sov-validators-state
StephenButtolph
changed the base branch from
implement-acp-77-sov-validators-state
to
implement-acp-77-deactivation
StephenButtolph
commented
Sep 26, 2024
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
…cp-77-deactivation
…cp-77-deactivation
…date-convert-subnet-tx
…cp-77-deactivation
marun
approved these changes
Nov 5, 2024
darioush
approved these changes
Nov 5, 2024
| ManagerChainID: chainID, | ||
| ManagerAddress: address, | ||
| }, | ||
| subnet, | ||
| ) | ||
| }) | ||
|
|
||
| tc.By("verifying the validator set was updated", func() { | ||
| verifyValidatorSet(map[ids.NodeID]*snowvalidators.GetValidatorOutput{ |
There was a problem hiding this comment.
curious what the expected validatorSet is before the conversion?
There was a problem hiding this comment.
Added as part of the test
github-merge-queue
bot
removed this pull request from the merge queue due to Branch Protection failures
You're not authorized to push to this branch. Visit "About protected branches" for more information.
ceyonur
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This PR updates the
ConvertSubnetTxto match the updated specification defined in ACP-77.How this works
ConvertSubnetTxin the spec now includes the initial validator set.SubnetConversionIDs and those are now populated.How this was tested
ConvertSubnetTxserialization tests are updatedConvertSubnetTxsyntactic verification tests are updatedConvertSubnetTxexecution tests are updatedConvertSubnetTxcomplexity tests are updatedConvertSubnetTxwallet builder tests are updated