ACP-77: Refactor e2e test #3522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
added
testing
marun
approved these changes
Nov 5, 2024
|
|
||
| address := []byte{} | ||
| tc.By("issuing a ConvertSubnetTx", func() { | ||
| _, err := pWallet.IssueConvertSubnetTx( |
There was a problem hiding this comment.
(No action needed) Curious/Surprised that IssueConvertSubnetTx doesn't take the initial L1 validators...is this just because the test is for the old spec that included RecoverSubnetTx?
There was a problem hiding this comment.
Correct. This PR was factored out of #3397 which adds the initial L1 validators.
michaelkaplan13
approved these changes
Nov 5, 2024
darioush
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This test is heavily extended by all of the remaining ACP-77 PRs. To simplify the review process, the non-behavioral changes that were included in those PRs were refactored into this single PR.
How this works
Just moving code around to make the test more extendable.
How this was tested
N/A
Need to be documented in RELEASES.md?
No.