Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lanelet2_extension): add util/visualization of BusStopArea #28

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

soblin
Copy link
Collaborator

@soblin soblin commented Sep 5, 2024

Description

add functions to

  • visualize BusStopArea
    image

  • query BusStopArea

Related links

Tests performed

tested using this map
https://github.com/autowarefoundation/autoware.universe/tree/main/planning/behavior_path_planner/autoware_behavior_path_planner_common/test_map/road_shoulder

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@soblin soblin marked this pull request as ready for review September 5, 2024 09:02
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 42 lines in your changes missing coverage. Please review.

Project coverage is 16.24%. Comparing base (9676d45) to head (9a652e3).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
autoware_lanelet2_extension/lib/visualization.cpp 0.00% 35 Missing ⚠️
autoware_lanelet2_extension/lib/query.cpp 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
- Coverage   16.48%   16.24%   -0.25%     
==========================================
  Files          42       42              
  Lines        2808     2850      +42     
  Branches     1371     1392      +21     
==========================================
  Hits          463      463              
- Misses       2252     2294      +42     
  Partials       93       93              
Flag Coverage Δ *Carryforward flag
differential 16.24% <0.00%> (-0.51%) ⬇️
total 16.48% <ø> (ø) Carriedforward from 07a7530

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

std::vector<geometry_msgs::msg::Polygon> triangles;
polygon2Triangle(geom_poly, &triangles);

for (auto tri : triangles) {
Copy link
Collaborator

@kosuke55 kosuke55 Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for (auto tri : triangles) {
for (const auto & tri : triangles) {

?

Signed-off-by: Mamoru Sobue <[email protected]>
@soblin soblin enabled auto-merge (squash) September 5, 2024 13:53
@soblin soblin merged commit 69f0e5e into main Sep 5, 2024
17 of 21 checks passed
@soblin soblin deleted the feat/add-bus-stop-area-query branch September 5, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants