-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(perception): fix perception docs #9766
fix(perception): fix perception docs #9766
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9766 +/- ##
==========================================
+ Coverage 29.66% 29.70% +0.04%
==========================================
Files 1450 1453 +3
Lines 108833 108860 +27
Branches 42740 42742 +2
==========================================
+ Hits 32285 32342 +57
+ Misses 73375 73340 -35
- Partials 3173 3178 +5
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d986c2b
to
9315445
Compare
Signed-off-by: vividf <[email protected]>
Signed-off-by: vividf <[email protected]>
9315445
to
6b00abd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some missing default values.
perception/autoware_object_merger/schema/data_association_matrix.schema.json
Outdated
Show resolved
Hide resolved
perception/autoware_object_merger/schema/data_association_matrix.schema.json
Outdated
Show resolved
Hide resolved
perception/autoware_object_merger/schema/data_association_matrix.schema.json
Outdated
Show resolved
Hide resolved
perception/autoware_object_merger/schema/data_association_matrix.schema.json
Outdated
Show resolved
Hide resolved
…ix.schema.json Co-authored-by: Taekjin LEE <[email protected]>
…ix.schema.json Co-authored-by: Taekjin LEE <[email protected]>
…ix.schema.json Co-authored-by: Taekjin LEE <[email protected]>
…ix.schema.json Co-authored-by: Taekjin LEE <[email protected]>
I saw some tables are merged together because the markdown interpreted those as a table
We need to set space between the script
Can you implement this change in similar places? or maybe more |
Signed-off-by: vividf <[email protected]>
@technolojin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* fix: fix perception docs Signed-off-by: vividf <[email protected]> * fix: fix missing parameter in schema Signed-off-by: vividf <[email protected]> * Update perception/autoware_object_merger/schema/data_association_matrix.schema.json Co-authored-by: Taekjin LEE <[email protected]> * Update perception/autoware_object_merger/schema/data_association_matrix.schema.json Co-authored-by: Taekjin LEE <[email protected]> * Update perception/autoware_object_merger/schema/data_association_matrix.schema.json Co-authored-by: Taekjin LEE <[email protected]> * Update perception/autoware_object_merger/schema/data_association_matrix.schema.json Co-authored-by: Taekjin LEE <[email protected]> * style(pre-commit): autofix * chore: seperate paramters for different nodes Signed-off-by: vividf <[email protected]> --------- Signed-off-by: vividf <[email protected]> Co-authored-by: Taekjin LEE <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
There are several pages in perception docs that are broken on the website.
This PR fixes the issue including the wrong path and schema error.
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.