-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(behavior_velocity_planner): independent of plugin packages #9760
refactor(behavior_velocity_planner): independent of plugin packages #9760
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
eed6aec
to
66b1008
Compare
Signed-off-by: Takayuki Murooka <[email protected]>
66b1008
to
90cae7c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9760 +/- ##
=======================================
Coverage 29.72% 29.72%
=======================================
Files 1451 1461 +10
Lines 108839 108938 +99
Branches 42741 42775 +34
=======================================
+ Hits 32348 32381 +33
- Misses 73313 73377 +64
- Partials 3178 3180 +2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@soblin |
…utowarefoundation#9760) Signed-off-by: Takayuki Murooka <[email protected]>
…utowarefoundation#9760) Signed-off-by: Takayuki Murooka <[email protected]>
Description
Currently, due to the node test, the behavior_velocity_planner depends on the plugin packages, which is unexpected because we introduced the ROS2's pluginlib so that the node will node depend on the plugin packages.
Referring to the the structure of the behavior_path_planner's node test, this PR changed the structure of the behavior_velocity_planner's node test.
https://github.com/autowarefoundation/autoware.universe/blob/main/planning/behavior_path_planner/autoware_behavior_path_planner/test/test_autoware_behavior_path_planner_node_interface.cpp
The node test in the plugin packages will be added by the succeeding PRs.
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.