refactor(autoware_geography_utils): apply modern C++17 style #109
+38
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
4 tasks
youtalk
force-pushed
the
refactor-geography-utils
branch
from
e6aaeb2 to
4194707
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
==========================================
- Coverage 79.18% 78.75% -0.44%
==========================================
Files 11 11
Lines 197 193 -4
Branches 75 73 -2
==========================================
- Hits 156 152 -4
Misses 11 11
Partials 30 30
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
youtalk
changed the title
youtalk
requested review from
anhnv3991,
Motsu-san,
RyuYamamoto,
SakodaShintaro,
TaikiYamada4,
YamatoAndo and
a team
as code owners
|
Since I restricted it to C++17 only, it can now be built as it is with the original |
xmfcx
reviewed
Dec 17, 2024
common/autoware_geography_utils/include/autoware/geography_utils/height.hpp
Show resolved
Hide resolved
xmfcx
reviewed
Dec 17, 2024
|
I've reviewed and added some comments, thanks for the improvements! |
xmfcx
reviewed
Dec 17, 2024
xmfcx
approved these changes
Dec 18, 2024
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
xmfcx
force-pushed
the
refactor-geography-utils
branch
from
01a3681 to
4079ced
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR applies modern C++17 style to
autoware_geography_utils.Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.