Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set CMAKE_CXX_STANDARD 20 #12

Closed
wants to merge 1 commit into from
Closed

feat: set CMAKE_CXX_STANDARD 20 #12

wants to merge 1 commit into from

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Dec 6, 2024

Description

This PR changes the CMAKE_CXX_STANDARD variable from 17 to 20.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk youtalk self-assigned this Dec 6, 2024
@xmfcx
Copy link
Contributor

xmfcx commented Dec 6, 2024

https://docs.ros.org/en/rolling/The-ROS2-Project/Contributing/Code-Style-Language-Versions.html#id2

Standard

Rolling targets C++17.

This is for ROS 2 rolling but I'm not sure if would cause an issue for us switching to C++20.

There is a length discussion here about it: https://discourse.ros.org/t/ros-2-and-c-20/34292/7 but I didn't go through all of it.

Is there a discussion post on this in Autoware side?

I was able to find this change through this PR:

@youtalk
Copy link
Member Author

youtalk commented Dec 6, 2024

I accidentally marked autowarefoundation/autoware.core#109 as Ready for review, but it is still in the draft stage. I am prototyping how much more refined it can be rewritten using C++20. Depending on the results, I will submit to the Discussions.

@youtalk
Copy link
Member Author

youtalk commented Dec 17, 2024

Since we need to continue supporting some older OS versions, we will withdraw this for now.

@youtalk youtalk closed this Dec 17, 2024
@youtalk youtalk deleted the use-c++20 branch December 17, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants