Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update CODEOWNERS #107

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Conversation

awf-autoware-bot[bot]
Copy link
Contributor

No description provided.

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link

github-actions bot commented Dec 6, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@awf-autoware-bot awf-autoware-bot bot merged commit f94c0f8 into main Dec 6, 2024
29 checks passed
@awf-autoware-bot awf-autoware-bot bot deleted the update-codeowners-from-packages branch December 6, 2024 01:40
@xmfcx
Copy link
Contributor

xmfcx commented Dec 6, 2024

@youtalk san, with this PR, nothing changes.

Because the latest pattern takes precedence.
This means us 3 own all files, things above won't matter.

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#example-of-a-codeowners-file

If you wanted to add us 3 as addition to existing codeowners, you should use global-codeowners parameter of the https://github.com/autowarefoundation/autoware-github-actions/blob/196ca1d50eef0fc7b898d85f7ccfe17b3c0e97b4/update-codeowners-from-packages/action.yaml#L12 action. You can add a team there. I created @autoware-core-global-codeowners if you need it.

@youtalk
Copy link
Member

youtalk commented Dec 6, 2024

@xmfcx Oh, I see.

You can add a team there. I created @autoware-core-global-codeowners if you need it.

Yes, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants