ci(sync-files): add global code owners #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: M. Fatih Cırıt <[email protected]>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: M. Fatih Cırıt <[email protected]>
Merged
|
@youtalk @mitsudome-r this is ready for review ✅ Order of operations:
|
youtalk
approved these changes
Dec 8, 2024
mitsudome-r
approved these changes
Dec 9, 2024
This was referenced Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds @autowarefoundation/autoware-core-global-codeowners team to all packages.
And removes the manual code owners.
Detailed explanation of how the ordering in this file works: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#example-of-a-codeowners-file
CODEOWNERS file before this PR
https://github.com/autowarefoundation/autoware.core/blob/701e814822e67d119345a9e41ee702ecd06f772e/.github/CODEOWNERS
Any rule that comes later overrides the rules above.
This means, because the later coming
* name1 name2rule is so broad and these will own all the files above. And any rules above won't have any meaning.CODEOWNERS file after this PR
This way, the CI will add
@autowarefoundation/autoware-core-global-codeownersautomatically to the each package. And this team will be assigned as an additional code owner to all packages.Related links
Similar to:
Follow up from:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.