Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use HTTP bindings correctly #579

Merged
merged 33 commits into from
Nov 23, 2023

Conversation

KhudaDad414
Copy link
Member

@KhudaDad414 KhudaDad414 commented Nov 15, 2023

Description

  • Refactor HTTP client code for better maintainablility.
  • Refactor HTTP server code for better maintainablility.
  • Make sure both client and server use HTTP bindings to validate the requests.
  • Make sure the request/reply works with the HTTP protocol.

Related issue(s)
Resolves #553

@KhudaDad414 KhudaDad414 marked this pull request as ready for review November 21, 2023 15:35
@KhudaDad414
Copy link
Member Author

@fmvilas @Souvikns please take a look when you have the time.

Copy link

sonarcloud bot commented Nov 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6946177953

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 69.331%

Files with Coverage Reduction New Missed Lines %
src/lib/util.ts 1 72.52%
Totals Coverage Status
Change from base Build 6945719552: -0.1%
Covered Lines: 368
Relevant Lines: 472

💛 - Coveralls

Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as my only comment should not block this PR.

@KhudaDad414
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 5f5040f into asyncapi:master Nov 23, 2023
12 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.31.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use the correct bindings for http client
4 participants