Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use the correct bindings for http client #553

Closed
Tracked by #518
KhudaDad414 opened this issue Oct 26, 2023 · 4 comments · Fixed by #579
Closed
Tracked by #518

use the correct bindings for http client #553

KhudaDad414 opened this issue Oct 26, 2023 · 4 comments · Fixed by #579
Assignees
@KhudaDad414
Labels
bug Something isn't working released

Comments

@KhudaDad414
Copy link
Member

Describe the bug

in the current codebase we are using the channel binding object. but we do not have channel bindings. https://github.com/asyncapi/bindings/tree/next-major-spec/http

officially we only have operations and messages biddings and glee should parse them from the operation not channel.
@KhudaDad414 KhudaDad414 added the bug Something isn't working label Oct 26, 2023
@KhudaDad414 KhudaDad414 mentioned this issue Nov 1, 2023
Closed
7 tasks
@KhudaDad414 KhudaDad414 self-assigned this Nov 10, 2023
@KhudaDad414
Copy link
Member Author

/progress 10

started working on the issue.

@KhudaDad414 KhudaDad414 mentioned this issue Nov 15, 2023
Merged
4 tasks
@KhudaDad414
Copy link
Member Author

/progress 60
opened a draft PR #579. Will resolve this issue after refactoring the HTTP Adapters.

@KhudaDad414
Copy link
Member Author

/progress 90
PR is ready for review.

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 0.31.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KhudaDad414 KhudaDad414

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use HTTP bindings correctly KhudaDad414/glee
2 participants
@KhudaDad414 @asyncapi-bot