Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix root folder reference #84
Fix root folder reference #84
Changes from 10 commits
bf63cca
c437548
09276ec
02e1989
d3bcc97
360a632
5d4c8eb
510ac96
3a7b868
97d3b2b
e49d5e6
48ca4e4
c6f6974
ff6d5b3
8a426ac
fb83f67
f7ae219
40fedc2
d4ca73a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixing a case that I found after merging my previous PR, as for the no-deploy case we want to simulate a change in a file outside the root folder. This is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also need some kind of validation that the root folder does not start with a forward slash, which presumably would not match with any
file
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree on having the validation, also there are a couple of other places that could benefit from having upfront validation rather than having to fail later. But I would prefer to decouple that from this patch release so that we are focused on fixing bugs introduced in 0.7. (Will drop an issue so that we don't loose track of it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue to track the change: #85
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently we run
astronomer/[email protected]
prior toastro deployment variable update
in CI. If there are no changes, this step fails. Will set theroot-folder
to see if that gets us moving forward. Ideally these changes could be versioned, if possible, though.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, since this is a fix, we are planning to release a
v0.7.1
with these PR changes